Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing elements ids #8961

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

fatmaBouchekoua
Copy link
Contributor

@fatmaBouchekoua fatmaBouchekoua commented Apr 19, 2018

Questions Answers
Branch? develop
Description? This PR adds an Id to some elements in order to use them in the automated tests
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@LittleBigDev
Copy link
Contributor

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


admin-dev/themes/new-theme/template/page_header_toolbar.tpl, line 98 at r1 (raw file):

  {/if}
  {if $current_tab_level == 3}
    <div class="page-head-tabs" id="head_tabs">

Are you sure about underscores ? Shouldn't it be consistent with classes ?


Comments from Reviewable

@fatmaBouchekoua
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


admin-dev/themes/new-theme/template/page_header_toolbar.tpl, line 98 at r1 (raw file):

Previously, LittleBigDev (Bastien Bieri) wrote…

Are you sure about underscores ? Shouldn't it be consistent with classes ?

I've used the old one (before the migration to Symfony)
There are ids everywhere with underscores and others with a hyphen.


Comments from Reviewable

@LittleBigDev
Copy link
Contributor

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


admin-dev/themes/new-theme/template/page_header_toolbar.tpl, line 98 at r1 (raw file):

Previously, fatmaBouchekoua (Fatma Bouchekoua) wrote…

I've used the old one (before the migration to Symfony)
There are ids everywhere with underscores and others with a hyphen.

ok then :)


Comments from Reviewable

Copy link
Contributor

@LittleBigDev LittleBigDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LittleBigDev LittleBigDev merged commit 31d6ed4 into PrestaShop:develop Apr 19, 2018
@eternoendless eternoendless added this to the 1.7.4.0 milestone Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants