Fix install/upgrade/upgrade.php for php-5.4 syntax

[transkontrol]

Questions	Answers
Branch?	"develop"
Description?	fix install/upgrade/upgrade.php for php-5.4 syntax
Type?	bug fix
Category?	IN
BC breaks?	no
Deprecations?	no
Fixed ticket?	-
How to test?	update application at php-5.4

[prestonBot]

Hello transkontrol!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

[xBorderie]

Thank you for your contribution!

Sadly, you now have malformed commits instead of just one commit:

• the initial commit, which follows the naming convention,
• one merge commit -- which if merged can break the repository's history!

Could you try and squash those commits into just one? Another explanation of squashing.

Thank you!

[transkontrol]

Sadly, you now have malformed commits instead of just one commit:

complete!

[Quetzacoalt91]

Actually, when we look at this function, we can find:

        public function hasFailure()
        {
            return !empty($this->failureList);
        }

I don't understand why we have an empty() at the first place.

if (!$upgrade->hasFailure()) {

should be enough.

[transkontrol]

Sorry, do you mean that you fix it now without PR?

[Quetzacoalt91]

It depends if you want a contribution on this. If you put the change in your PR, I will merge it. Otherwise I wil open another one. 😉

[Quetzacoalt91]

Perfect, thank you @transkontrol