Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional Tests : Remove eslint-config-prestashop & Bump eslint - eslint-config-airbnb-base #30030

Merged
merged 6 commits into from
Nov 8, 2022
Merged

Functional Tests : Remove eslint-config-prestashop & Bump eslint - eslint-config-airbnb-base #30030

merged 6 commits into from
Nov 8, 2022

Conversation

Progi1984
Copy link
Member

Questions Answers
Branch? develop
Description? Functional Tests : Remove eslint-config-prestashop & Bump eslint - eslint-config-airbnb-base
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Related PRs N/A
How to test? N/A
Possible impacts? N/A

@Progi1984 Progi1984 added TE Category: Tests E2E Tests labels Oct 17, 2022
@Progi1984 Progi1984 added this to the 8.1.0 milestone Oct 17, 2022
@Progi1984 Progi1984 requested a review from a team as a code owner October 17, 2022 12:11
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Oct 17, 2022
boubkerbribri
boubkerbribri previously approved these changes Oct 17, 2022
View reviewed changes
@Progi1984 Progi1984 marked this pull request as draft October 17, 2022 12:39
NeOMakinG
NeOMakinG previously approved these changes Oct 17, 2022
View reviewed changes
@boubkerbribri boubkerbribri added the Blocked Status: The issue is blocked by another task label Oct 26, 2022
@Progi1984 Progi1984 marked this pull request as ready for review October 31, 2022 12:56
@Progi1984 Progi1984 marked this pull request as draft October 31, 2022 12:56
@Progi1984
Copy link
Member Author

@NeOMakinG & @boubkerbribri I rebased the PR 😉

@boubkerbribri boubkerbribri removed the Blocked Status: The issue is blocked by another task label Nov 7, 2022
@Progi1984 Progi1984 marked this pull request as ready for review November 8, 2022 07:53
@Progi1984 Progi1984 added the QA ✔️ Status: check done, code approved label Nov 8, 2022
@matthieu-rolland matthieu-rolland merged commit 9236278 into PrestaShop:develop Nov 8, 2022
@matthieu-rolland
Copy link
Contributor

thank you @Progi1984 !

@Progi1984 Progi1984 deleted the removeEslintConfigPrestashop branch November 8, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@nesrineabdmouleh nesrineabdmouleh nesrineabdmouleh approved these changes

@boubkerbribri boubkerbribri Awaiting requested review from boubkerbribri

Assignees
No one assigned
Labels
develop Branch E2E Tests Improvement Type: Improvement QA ✔️ Status: check done, code approved TE Category: Tests
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Progi1984 @matthieu-rolland @NeOMakinG @nesrineabdmouleh @boubkerbribri @prestonBot