Sourcery refactored main branch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
force-pushed
the
sourcery/main
branch
from
311adba
to
5d73d60
Compare
| match = functionNameRegex.match(line) | ||
| if match: | ||
| if match := functionNameRegex.match(line): |
There was a problem hiding this comment.
Function matchFunctionName refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-102
to
+101
| isLastParameter = True if end is not None and end == ')' else False | ||
| isLastParameter = end is not None and end == ')' |
There was a problem hiding this comment.
Function matchParameter refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
Comment on lines
-107
to
+106
| return True if openingCurlyBraceRegex.match(line) is not None else False | ||
| return openingCurlyBraceRegex.match(line) is not None |
There was a problem hiding this comment.
Function matchOpeningCurlyBrace refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
Comment on lines
-121
to
+120
| if not matchOpeningCurlyBrace(nextLine): | ||
| return 0 | ||
| return i + 1 | ||
| return 0 if not matchOpeningCurlyBrace(nextLine) else i + 1 |
There was a problem hiding this comment.
Function getFunctionDeclarationLength refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-128
to
+125
| parameterInfos = [] | ||
| for i in range(length): | ||
| parameterInfos.append(matchParameter(remainingLines[i])) | ||
| return parameterInfos | ||
| return [matchParameter(remainingLines[i]) for i in range(length)] |
There was a problem hiding this comment.
Function getParameterInfos refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-36
to
+38
| def get_random_file_index (): | ||
| def get_random_file_index(): | ||
| n = len (files) | ||
| if n == 0: | ||
| return -1 | ||
| else: | ||
| return random_gen.randrange (n) | ||
| return -1 if n == 0 else random_gen.randrange (n) |
There was a problem hiding this comment.
Function get_random_file_index refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-43
to
+42
| def get_random_directory_index (): | ||
| def get_random_directory_index(): | ||
| n = len (directories) | ||
| if n == 0: | ||
| return -1 | ||
| else: | ||
| return random_gen.randrange (n) | ||
|
|
||
| def get_random_filename (): | ||
| chars = [] | ||
| for i in range (20): | ||
| chars.append ("abcdefghijklmnopqrstuvwxyz"[random_gen.randrange (26)]) | ||
| return -1 if n == 0 else random_gen.randrange (n) |
There was a problem hiding this comment.
Function get_random_directory_index refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
| def get_random_filename (): | ||
| chars = [] | ||
| for i in range (20): | ||
| chars.append ("abcdefghijklmnopqrstuvwxyz"[random_gen.randrange (26)]) | ||
| return -1 if n == 0 else random_gen.randrange (n) | ||
|
|
||
| def get_random_filename(): | ||
| chars = [ | ||
| "abcdefghijklmnopqrstuvwxyz"[random_gen.randrange(26)] | ||
| for _ in range(20) | ||
| ] | ||
| extension = extensions[random_gen.randrange (len (extensions))] | ||
| filename = "".join (chars) + extension | ||
| return filename | ||
| return "".join (chars) + extension |
There was a problem hiding this comment.
Function get_random_filename refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Replace unused for index with underscore (
for-index-underscore) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
pull bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
The mutter portion of the comment isn't relavent after [1] and #1 was resolved in [2] [1] https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/179 [2] https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!