Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bambda: Extract JSON data from WebSocket message, add it to Notes #55

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Bambda: Extract JSON data from WebSocket message, add it to Notes #55

merged 2 commits into from
Jan 19, 2024

Conversation

ncoblentz
Copy link
Contributor

Bambda Contributions

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda compiles and executes as expected
  • Only .bambda files have been added or modified (README.md files are automatically updated / generated after PR merge)

ps-porpoise
ps-porpoise approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@ps-porpoise ps-porpoise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR looks great, thanks for your submission! I've moved it into the Proxy/WS directory as our auto-readme generation assumes WS bambdas belong there.

PortSwiggerWiener
PortSwiggerWiener approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your submission.

Looks good. 👍

@PortSwiggerWiener PortSwiggerWiener merged commit 09a6754 into PortSwigger:main Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PortSwiggerWiener PortSwiggerWiener PortSwiggerWiener approved these changes

@ps-porpoise ps-porpoise ps-porpoise approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncoblentz @PortSwiggerWiener @ps-porpoise