Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New implementation for custom log channel, if LogTemp is not desired #121

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

nassosterz-ms
Copy link
Contributor

What this PR does / why we need it:
Fixes bug introduced by reusing the log channel declared in PlayFabGSDK.h, since packaging fails with the current code.

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

Copy link
Contributor

@pgilmorepf pgilmorepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I like this even better than reusing the module logger.
The sample is separate from the module, so it having a separate log channel is awesome.
Good job.

@dgkanatsios dgkanatsios merged commit 4abd630 into main Mar 28, 2022
@dgkanatsios dgkanatsios deleted the nt/fix-log-channel branch March 28, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants