Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped setting up default server around if server clause #109

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

nassosterz-ms
Copy link
Contributor

@nassosterz-ms nassosterz-ms commented Nov 30, 2021

What this PR does / why we need it:
For Windows Process and Container on TH build fails when this code is executed by client.

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@@ -215,6 +213,7 @@ If you already **had** an Init() function, go to check in [YourGameInstanceClass

```cpp
#if UE_SERVER
UGSDKUtils::SetDefaultServerHostPort();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it work for container based servers as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we tested it all the ways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will update PR description

@@ -215,6 +213,7 @@ If you already **had** an Init() function, go to check in [YourGameInstanceClass

```cpp
#if UE_SERVER
UGSDKUtils::SetDefaultServerHostPort();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we tested it all the ways.

@nassosterz-ms nassosterz-ms merged commit f6ae897 into master Nov 30, 2021
@nassosterz-ms nassosterz-ms deleted the nt/wrap-around-if-server branch November 30, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants