Update distribution artifact repo url #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amccalib
requested changes
Jul 28, 2022
| @@ -3,7 +3,7 @@ | |||
| ## ~~0. Install via Maven or Gradle:~~ | |||
| > Note: The PlayFab SDK Maven package is out of date. We are working to update to the latest. For now, to get the latest Java SDK for your game, you will need to clone this repo and build from source. | |||
|
|
|||
| Check the [Maven Central Repository](https://search.maven.org/#search%7Cga%7C1%7Ccom.playfab) for latest versions of our SDKs. | |||
| Check the [Public Artifact Repository](https://dev.azure.com/PlayFabInternal/Main/_artifacts/feed/PlayFab-JavaSDK-combined) for latest versions of our SDKs. | |||
There was a problem hiding this comment.
Can you confirm this url is publicly accessible? Should we be hosting the artifact on GitHub instead?
There was a problem hiding this comment.
I can confirm a private browser window without logging into ado can access the jar files from the url.
GitHub sounds like it would be more official and may not require the README update as is if we are able to automate packaging through ADO.
There was a problem hiding this comment.
Alright. I'm fine hosting this on ADO.
amccalib
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.