refresh_variable broken due to recent commit

[clienthax]

Describe the bug

Commit 0b47a3a changed behaviour of parse_value_from_xml_last_tag to require an additional argument

refresh_variable does not pass the new required argument to parse_value_from_xml_last_tag here

pan-os-python/panos/base.py

Line 959 in 0b47a3a

var_path.parse_value_from_xml_last_tag(obj, settings)

Expected behavior

It to work

Current behavior

  File "/usr/local/lib/python3.8/dist-packages/panos/base.py", line 970, in refresh_variable
    var_path.parse_value_from_xml_last_tag(obj, settings)
TypeError: parse_value_from_xml_last_tag() missing 1 required positional argument: 'attr'

Possible solution

Add the missing argument to the caller

Steps to reproduce

Use pan-os-ansible to gather facts from a host.

Context

Gathering facts from network devices using ansible

Your Environment

• Version used: ab4d088
• Environment name and version (e.g. Chrome 59, node.js 5.4, python 3.7.3): N/A
• Operating System and version (desktop or mobile): N/A
• Link to your project: N/A

[welcome-to-palo-alto-networks]

🎉 Thanks for opening your first issue here! Welcome to the community!

[jhlasnik]

I also hit this same issue, rolling back to v1.6.0 has resolved my issue for the time being.

[github-actions]

🎉 This issue has been resolved in version 1.7.2 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot