Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add indextype #56112

Merged
merged 3 commits into from
Aug 11, 2023
Merged

add indextype #56112

merged 3 commits into from
Aug 11, 2023

Conversation

zhangbopd
Copy link
Contributor

@zhangbopd zhangbopd commented Aug 9, 2023

PR types

Others

PR changes

Others

Description

IR 的 builtin dialect 中加入 IndexType

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Aug 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhangbopd zhangbopd requested review from zhangbo9674 and winter-wang and removed request for zhangbo9674 August 9, 2023 08:25
zhangbo9674
zhangbo9674 previously approved these changes Aug 9, 2023
///
/// \brief This class represents the base of a type interface.
///

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段 TypeInterface 是后续需要添加的么,如果不是,后续可以删除这段无用的代码

Copy link
Contributor Author

@zhangbopd zhangbopd Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,刚发现这个文件没有清理干净,后续 PR 增加 TypeInterface 会进行删改

@lanxianghit lanxianghit merged commit 34e9057 into PaddlePaddle:develop Aug 11, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants