Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][B017] catch more specific exceptions in unittests #52553

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Apr 5, 2023

PR types

Others

PR changes

Others

Describe

详情见 #51729 (comment)

  • 是否可以引入本 rule:✅ 如上所述,可以引入
  • 是否可引入自动修复:无自动修复功能

本 PR 同时解决了一些增量问题和修改配置以收尾 Ruff 引入工作

Bugbear 和 Pylint rules 的配置不采取 ignore 的形式,因为引入的不多,而且 Ruff 的新版本还在为它们持续增加部分新 rules,如果使用 ignore 的形式在未来升级 Ruff 需要对配置有较多的改动

Related links

PCard-66962

@paddle-bot
Copy link

paddle-bot bot commented Apr 5, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants