[static code gen]add error msg in composite maker code gen #51211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
… fix_static_code_gen
… fix_static_code_gen
… fix_static_code_gen
zyfncg
reviewed
Mar 9, 2023
| @@ -691,6 +692,29 @@ class {{op_name | to_composite_grad_opmaker_name}} : public prim::CompositeGradO | |||
| {%- endfor %} | |||
| {%- endmacro %} | |||
|
|
|||
| construct_composite_tensor_attr(attrs, fluid_attrs, attr_dict) | |||
| {% for i in range(attrs_length) %} | ||
| {% if "tensor_name" in attr_dict[attrs[i]] %} | ||
| auto {{'tensor_' + attrs[i]}} = this->GetOptionalSingleForwardInput("{{attr_dict[attrs[i]]['tensor_name']}}"); | ||
| if ({{'tensor_' + attrs[i]}}.is_initialized()) { |
There was a problem hiding this comment.
能否直接使用if进行判断，is_initialized和tensor成员函数名相同了，使用auto类型时容易引起误导
Comment on lines
702
to
704
| PADDLE_THROW(platform::errors::Unimplemented( | ||
| "We don't support dynamic tensor attribute for {{op_name}} composite" | ||
| "for now. ")); |
zyfncg
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Pcard-66975
由于组合算子不支持
Tensor attribute，因此在composite grad maker中为组合算子使用到Tensor attribute添加报错.