Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][py2] remove python2 installation from Dockerfile.ubuntu #48685

Merged
merged 6 commits into from
Jan 3, 2023

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Dec 3, 2022

PR types

Others

PR changes

Others

Describe

  • 测试下 CI 上是否会 build docker image
  • 移除 pip install xxx
  • 移除 python2
  • python 软链到 python3.7

本 PR 完成 Python2 退场计划1中的「删除非必要的环境依赖」,将 Dockerfile.ubuntu 中安装的 Python2 移除,并将对应的 pip(即命令 pip)安装相关依赖项命令移除

移除 Python2.7 后,将通过软链接的方式将 pythonpip 链接到 Python3.7,即 pythonpippython3pip3python3.7pip3.7 命令都是对应 3.7 版本的 Python / pip。

此外做了如下修改:

  • 直接安装最新版本 pip,移除命令 pip3.x --no-cache-dir install --upgrade pip,以精简 Dockerfile 步数
  • 清理专门给 Python2 安装的 setuptools-40.6.2,仅仅下载并安装 setuptools-50.3.2

Footnotes

  1. [CodeStyle] Legacy python code cleanup tracking issue #46837

@paddle-bot
Copy link

paddle-bot bot commented Dec 3, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Dec 3, 2022
@SigureMo SigureMo changed the title [CodeStyle][py2] test dockerfile [CodeStyle][py2] remove python2 in Dockerfile.ubuntu Dec 3, 2022
@SigureMo SigureMo changed the title [CodeStyle][py2] remove python2 in Dockerfile.ubuntu [WIP][CodeStyle][py2] remove python2 in Dockerfile.ubuntu Dec 3, 2022
@SigureMo SigureMo changed the title [WIP][CodeStyle][py2] remove python2 in Dockerfile.ubuntu [WIP][CodeStyle][py2] remove python2 installation from Dockerfile.ubuntu Dec 3, 2022
@SigureMo SigureMo force-pushed the py2/fix/dockerfile branch 5 times, most recently from f8a6ba1 to 730d261 Compare December 4, 2022 10:35
@luotao1 luotao1 self-assigned this Dec 5, 2022
@SigureMo SigureMo changed the title [WIP][CodeStyle][py2] remove python2 installation from Dockerfile.ubuntu [CodeStyle][py2] remove python2 installation from Dockerfile.ubuntu Dec 7, 2022
@luotao1
Copy link
Contributor

luotao1 commented Dec 8, 2022

@pangyoki 建议的提测流程:镜像更新一般需要做一个镜像,给qa测试这个镜像功能有没有问题。看这个pr里是删除python2.7,就需要做完镜像后,测试镜像里是否没有python2.7了,默认是否是python3.7,python3.7 paddle的编译是否有问题。

@luotao1
Copy link
Contributor

luotao1 commented Dec 9, 2022

感谢 @zhengqiwen1997 下周会帮忙build一个镜像,并走一下提测流程。

@luotao1
Copy link
Contributor

luotao1 commented Dec 20, 2022

感谢 @zhengqiwen1997 build 镜像,地址在:zhengqiwen/paddle:latest-dev-cuda11.2.1-cudnn8-gcc82-test

辛苦 @XieYunshen 帮忙测试下镜像:

  • 是否没有python2.7了,默认是否是python3.7,python3.7 paddle的编译是否有问题。

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 42fb43e into PaddlePaddle:develop Jan 3, 2023
@SigureMo SigureMo deleted the py2/fix/dockerfile branch January 3, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants