Function provider for simple methods registration as C1 functions #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename ServiceFunctionProvider into CodeBasedFunctionProvider (have not found better name, and since we execute functions both from ServiceLocator and Activator, and direct call, somehow should be renamed) - Extended MethodBasedFunction to be reusable; - Integrated CodeBasedFunctionProvider into C1
napernik
suggested changes
May 18, 2020
Composite/Plugins/Functions/FunctionProviders/CodeBasedFunctionProvider/CodeBasedFunction.cs
Outdated
Show resolved
Hide resolved
...lugins/Functions/FunctionProviders/CodeBasedFunctionProvider/CodeBasedFunctionEntityToken.cs
Outdated
Show resolved
Hide resolved
napernik
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey:) This is the integration of ServiceProvider from EM to C1 with updates
The name had to be changed because not only SP used now, but still it can be updated somehow