actoranimation.cpp faster getbonebyname

[bosvensson1]

While reviewing uses of the slow linear search FindByNameVisitor during my last PR, I stumbled upon some uses that we can refactor into a faster logarithmic search using a map already built. Somehow most of these lines are never triggered in my game so I will need an advise if we are using this code anymore and if my changes are OK.

[psi29a]

@unelsson gave his blessing here as well. 👍🏼

[psi29a]

Sorry @bosvensson1 but it seems that this caused an issue for weapon/shield sheathing so I had to revert.

Looks like it isn't used for what we would expect to use it for based on its name (finding bones in the actor's skeleton), instead, it seems to be used to find nodes in attached parts like weapon meshes.

This isn't obvious from the code, only our docs tells you where the nodes are supposed to be.

@akortunov do you have any insight here? Should we perhaps change the name of the function or at least comment about what this does in code?

[bosvensson1]

Reviewing the docs of weapon sheathing it seems I made a mistake and we still have to use FindByNameVisitor in most cases. We could still make the searches more efficient by searching only the subgraph where we expect the node to be. Unfortunately the docs do not mention where Bip01 AttachShield is supposed to be. I have moved on to more worthwhile performance improvements in the meantime. Akortunov is welcome to take over the suggestions from this thread if deemed worthwhile.

[akortunov]

Unfortunately the docs do not mention where Bip01 AttachShield is supposed to be.

It is supposed to be a part of actor scene node.