Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume failed scripts execution after game reload #2969

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

akortunov
Copy link
Collaborator

@akortunov akortunov commented Jul 14, 2020

Implements feature #5524.

Use a simple approach so far - once script execution fails during runtime, do not remove its bytecode, mark it as inactive instead.
When try to run a script, early-out when it is marked as inactive.
This flag is cleaned up during scripting system cleanup, during new game start or savegame loading.

Later it should be possible to per-instance blocks, but it is unclear how exactly it should work.

Note that I do not see the code, which removes data from mScripts map, so I assume that data persists for the whole game session.

@psi29a
Copy link
Member

psi29a commented Jul 14, 2020

It looks alright to me, waiting on AV. Thanks @akortunov

@psi29a psi29a merged commit e98ae32 into OpenMW:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants