Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge conflicts #2834

Merged
merged 1 commit into from
May 12, 2020
Merged

Fix merge conflicts #2834

merged 1 commit into from
May 12, 2020

Conversation

akortunov
Copy link
Collaborator

Fix conflict between #2648 and #2716 - both pull request increased a savegame format version from 5 to 6.
Solution: increase savegame format from 6 to 7, move new changelog entry from 0.46 to 0.47.

@akortunov akortunov merged commit f1786f1 into OpenMW:master May 12, 2020
@psi29a
Copy link
Member

psi29a commented May 12, 2020

We won't have to do this for other save game format changes correct? I mean, one format change per release is alright.

@akortunov
Copy link
Collaborator Author

I mean, one format change per release is alright.

No, we should increase its version every time when we change it.

@Capostrophic
Copy link
Collaborator

Strictly speaking we probably should, as if this isn't done some revisions of openmw may break horribly upon loading saves that seem to have the same format but don't. This seems to be the reasoning for format update here as well. Ninja'd.

@psi29a
Copy link
Member

psi29a commented May 12, 2020

Roger that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants