-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mwphysics refactoring (task #5338) #2748
Conversation
I suppose that you use a forward declaration via "class" keyword for some structures. |
I did my best to explain what it did in the responses to the PR so that it wouldn't be that much of a problem if/when something like this happened anyway. Worst case scenario it can be rewritten. |
LGTM. |
Taken! |
Task page
Put result callbacks, physics system constants, stepper and movement solver into dedicated header and implementation files, and port over some of wareya's consistency fixes in actor tracer class (make ClosestNotMeConvexResultCallback less nonsensical and use Misc::Convert functions more wherever possible).
Of course the mergeability of wareya's PR in its current state is ruined but I think we weren't going to merge that as is anyway.
And of course git blame is also ruined
a small price to pay for salvation.I tried to minimize the chosen dependencies, but may have put more than necessary somewhere (mainly to make sure files are buildable even if they are required outside of physics system implementation).
This allows to remove 600 lines from physics system implementation.
From the user's point of view nothing has changed so I don't think updating the changelog or putting anything on .46 milestone is necessary.