Make Show fallback to global variables when sensible (bug #5278) #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsid
reviewed
Feb 9, 2020
| @@ -923,11 +923,7 @@ namespace MWScript | |||
| if (!ptr.isEmpty()) | |||
| { | |||
| const std::string& script = ptr.getClass().getScript(ptr); | |||
| if (script.empty()) | |||
| { | |||
| output << ptr.getCellRef().getRefId() << " has no script " << std::endl; | |||
There was a problem hiding this comment.
How do a user see a difference is it a global variable or a script variable?
There was a problem hiding this comment.
I have now changed the format to the way vanilla does it with slight deviations (a member separator, dot instead of ->, the case of the original variable name isn't preserved). Hopefully it's clear enough.
elsid
reviewed
Feb 9, 2020
| default: | ||
| output << "unknown local '" << var << "' for '" << ptr.getCellRef().getRefId() << "'"; | ||
| break; | ||
| // Do nothing otherwise |
There was a problem hiding this comment.
Useless comment. It's obvious that there is nothing else in this switch statement.
There was a problem hiding this comment.
Arguably it demonstrates to the reader that all possible switch cases were considered. Ok, I'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug report.
In case there isn't a local variable for the given object, Show will try to find a global namesake.
The way stringstream emptiness is detected is somewhat clunky, but I don't want to actually recover the string that is put into it before it's actually necessary.