Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher: improve first run and missing game data dialogues (bug #4009) #2628

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

Capostrophic
Copy link
Collaborator

Fixes some oversights in these dialogues as reported by scrawl here.

  1. Skip Button of missing game data dialogue is now really called Skip. Instead of making both buttons Cancel (and make both exit the launcher), I decided to make it consistent with the first run dialog.
  2. Missing game data dialog isn't shown if the first Skip is pressed.
  3. It is, however, shown if the game data ended up being missing due to a run of Wizard. Pressing Skip will allow you to get out of the "loop" if you decide to run the Wizard a few times. Previously you could manage not to actually setup the game in the Wizard and get into the empty launcher.
  4. Widgets really were created twice due to a setup() hack in wizardFinished() event, which actually made missing game data dialogue horribly broken (it created another launcher which didn't react to settings changes, and that's actually the issue in the report, as noted by akortunov). Just removing the call won't work, as it makes some other necessary changes and it is necessary if pages are never created before it's called in wizard finished event. I've added a workaround into createPages() which seems to work: the pages are no longer recreated unnecessarily and the launcher gets properly reloaded.

Also I cleaned up how first run dialog and game data dialog states were managed a little.

@akortunov akortunov merged commit 1e62115 into OpenMW:master Dec 9, 2019
@Capostrophic Capostrophic deleted the launcher branch December 9, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants