Make sure quick key 0 (tenth quick key) shortcut is not saved or loaded #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor oversight caused oddities with older saves when they're loaded in 0.45.0 or later revisions of OpenMW (e.g. see here). Basically, quick key 0 or hand-to-hand shortcut could be bound to an action in 0.44.0 and earlier and then when in 0.45.0 that functionality was removed (to replicate Morrowind behavior) the quick key could only be assigned to that exact action in the saves where it was reallocated.
Now it's not saved or loaded, so it's dropped from the save where it was touched erroneously. The saved game format isn't changed, both backward and forward compatibility of the saved games is kept thanks to the current design of quick keys saving being flexible enough (you can load the save made with this fix in 0.45.0 and it will not have the issue). It even makes saves an extremely small bit smaller.
Should be minor enough not to require a changelog entry.