Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert questionable input manager decisions #2455

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

Capostrophic
Copy link
Collaborator

These are some things people have been complaining about and some things I personally dislike about input changes introduced during gamepad behavior improvements. They weren't given much of a thought before implementation.

  • Remove frankly unuseful Options Menu shortcut (I'm not sure if people are even aware of its existence).
  • Revert to more pleasant 0.45.0 Escape behavior -- currently it purely toggles the main menu, like vanilla, but people complained about it not working as it did previously -- and it closed the current GUI mode. Any subsequent improvements must first be discussed as feature requests.
  • Re-enable keyboard GUI arrow conversion feature -- while gamepads got DPAD arrows working for that, keyboards only got arrows for that again, but people liked that WASD or whatever set up as movement controls worked like GUI arrows. I don't have a gamepad so I can't test any possible improvements of gamepad behavior.
  • Remove gamepad button release handling -- currently just dead code untouched for months triggering my non-existent OCD.

May need a review from gamepad people, because from as far as I can tell B button works kind of similarly to Escape now, and I'm unsure if test that should block DPAD from triggering button release twice works as intended. Also, maybe someone liked options menu being available directly on gamepads and I must put that back immediately.

Remove Options Menu shortcut
Revert to more pleasant 0.45.0 Escape behavior
Re-enable keyboard GUI arrow conversion feature
Remove gamepad button release handling
@Capostrophic
Copy link
Collaborator Author

Capostrophic commented Aug 20, 2019

So far two gamepad users stated this works fine.

@Capostrophic
Copy link
Collaborator Author

Taking two reports as a confirmation this works as intended, merging since these are fixes for things that have lots of complaints, or basically regression fixes.

@Capostrophic Capostrophic merged commit 43a58e1 into OpenMW:master Aug 24, 2019
@Capostrophic Capostrophic deleted the input branch August 24, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant