Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hackish particle setup #2446

Closed
wants to merge 3 commits into from
Closed

Conversation

mp3butcher
Copy link
Contributor

@mp3butcher mp3butcher commented Jul 10, 2019

don't know if i'm right but it doesn't seems to break anything
tell me if you know the problem adressed by previous code or find broken stuff

don't know if i'm right but it doesn't seems to break anything
// HACK: ParticleSystem has no setReferenceFrame method
if (rf == osgParticle::ParticleProcessor::ABSOLUTE_RF)
{
partsys->getOrCreateUserDataContainer()->addDescription("worldspace");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that this decription is used in the SceneManager.

Copy link
Contributor Author

@mp3butcher mp3butcher Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...yes but it doesn't seems to change anything...my guess is it comes from osg 3.2 bug

@mp3butcher mp3butcher closed this Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants