remove an expensive call to normalize #2395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ void perLight(out vec3 ambientOut, out vec3 diffuseOut, int lightIndex, vec3 vie | |||
|
|
|||
| lightDir = gl_LightSource[lightIndex].position.xyz - (viewPos.xyz * gl_LightSource[lightIndex].position.w); | |||
| lightDistance = length(lightDir); | |||
| lightDir = normalize(lightDir); | |||
| lightDir = lightDir / lightDistance; | |||
There was a problem hiding this comment.
Zero division might cause issues.
There was a problem hiding this comment.
arf you may be right...
Capostrophic
added a commit
to Capostrophic/openmw
that referenced
this pull request
May 22, 2019
Capostrophic
added a commit
to Capostrophic/openmw
that referenced
this pull request
May 31, 2019
akortunov
added a commit
that referenced
this pull request
Jun 10, 2019
Content selector: don't add file namesakes (bug #2395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.