Fix zero division in enchantment magnitude calculation #2326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This zero division led to constant magnitude effects of enchanted items being not only unable to work, but also make the relevant stats of the character 0 or worse. Oops.
Now random multiplier is only calculated if the delta is not 0, like for constant abilities. It should be initialized as zero otherwise and the item will use the minimum magnitude in the result, which is what we want.