Enable light sources directly to avoid virtual calls #2274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on bzzt's changes.
The
setAssociatedModes
is supposed to fill the ModeUsage viagetModeUsage()
and apply specified changes to the stateset.Currently we use it to enable light sources.
In theory, we can enable light sources directly via a quite common OSG code pattern to avoid overhead.
As a result, every stateset creation in the LightManager takes about 1 microsecond less time.