Make magic teleportation attempts detectable even when teleportation is disabled (bug #3765) #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capostrophic
force-pushed
the
teleporting
branch
from
e1f92ef
to
05e3263
Compare
Capostrophic
force-pushed
the
teleporting
branch
from
05e3263
to
c9c94f9
Compare
Capostrophic
force-pushed
the
teleporting
branch
from
c9c94f9
to
7a7e390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 3765
Add teleportation effects to the list even if they're not going to work due to teleportation being disabled. Disabled teleportation handling was moved from checkEffectTarget to applyInstantEffect. This allows them to be detected by scripting, and also allows teleportation magic VFX to play properly even if teleportation is disabled, which is what I observe in Morrowind.
Also I reduced Intervention effects code duplication.
Works in my testing of a script that simply checks
player->getEffect sEffectMarkevery frame to show a messagebox: