Use the skeleton from the NPC's set model (bug #4747) #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capostrophic
force-pushed
the
skeleton
branch
from
1375c54
to
37fe9bd
Compare
|
Resolved the merge conflict. Is there anything that I missed or needs attention? |
|
It appears that Animated Morrowind and Arktwend need this too - there are a bunch of bone-related warnings for Animated Morrowind and Arktwend animations when running Arktwend about standard skeletons lacking tail and left/right toe bones, although they don't seem to use them unlike rot's replacement animations. |
terabyte25
approved these changes
Jan 2, 2019
Capostrophic
force-pushed
the
skeleton
branch
from
37fe9bd
to
6660f2f
Compare
psi29a
reviewed
Feb 22, 2019
| addAnimSource("meshes\\xargonian_swimkna.nif", smodel); | ||
| } | ||
| if(!isWerewolf && Misc::StringUtils::lowerCase(mNpc->mRace).find("argonian") != std::string::npos) | ||
| addAnimSource("meshes\\xargonian_swimkna.nif", smodel); |
There was a problem hiding this comment.
ugh... hardcoded stuff... we should get away from this ASAP
psi29a
added a commit
that referenced
this pull request
Sep 20, 2020
Make NiFlipControllers only affect base texture Closes #2069 See merge request OpenMW/openmw!301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 4747.
Previously only the animations and not the skeleton were used from the mModel field in NPC record. This caused NPCs with changed model often lack the nodes necessary to perform the animations from the models or use set body parts of their race.
Now non-werewolf NPCs will use the skeleton of the model set in their record and fallback to their default skeleton otherwise; animations of the default skeleton will be added too, "just in case". As I said under the report, rot has confirmed this should be fine.
This is Teleri Helvi with Khajiit race with Beast flag unchecked. rot's files allow NPCs with it assigned to have tail if it's assigned to their race.
In master, furry Teleri lacks a tail and there are multiple errors and warnings logged:
With these changes they are no more.