Fix Equip command stack overflow (bug #3072) #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinnschlag
added a commit
that referenced
this pull request
Aug 17, 2018
akortunov
added a commit
to akortunov/openmw
that referenced
this pull request
Sep 23, 2018
akortunov
added a commit
to akortunov/openmw
that referenced
this pull request
Sep 23, 2018
akortunov
added a commit
to akortunov/openmw
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 3072.
Use the force argument recently added by akortunov for Equip command specifically to decide whether we should run the script in useItem or not. As far as I can tell this still allows the script to run every frame, so you can hear the equip sound, you can't use the inventory, etc. when an item that has a "broken" script is added to the inventory, like in Morrowind.
And when you use the plugin from bug 4556, which is a duplicate of bug 3072, the testring item works as an un-unequippable ring, as it should.