Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked trade window #1555

Merged
1 commit merged into from
Nov 21, 2017
Merged

Reworked trade window #1555

1 commit merged into from
Nov 21, 2017

Conversation

akortunov
Copy link
Collaborator

@akortunov akortunov commented Nov 19, 2017

  1. Use AutoSizedTextBox instead of TextBox (should fix the trade window issue from bug #4215).
  2. Increased minimum window width to handle more long labels (have we a better solution? Ideally, buttons should not overlap each others.)
  3. Every line is wrapped to the HBox, so PlayerGold and MerchantGold can use a "Right" alignment.

@ghost
Copy link

ghost commented Nov 20, 2017

Can we not increase the width of the number edit box? It's already hideously wide as it is. If at all, the width should match the english label which is what most players would see.Looks like your PR didn't make the edit box wider. I could swear it was smaller before. Maybe it should be, anyway...

I tested some alternate layouts to use that extra horizontal space for the +/- buttons, but I don't really like them. The first one is too hard to click on and the other ones you have to move your mouse more to go from + to -.

layout1
layout2
layout3

@akortunov
Copy link
Collaborator Author

I thought about alternative layouts too:
1
2
3

But text labels may have different length on different languages.

@akortunov
Copy link
Collaborator Author

Or something like:

4

@ghost
Copy link

ghost commented Nov 21, 2017

The last one is quite nice. Actually using '>>' for 'Max Sale' would solve an issue with the german version (or all localised versions?) where they forgot to translate the label.

But the one thing I don't like about it is how the '+' and '-' don't match up vertically. I guess that can't be fixed as it's a problem with the font.

@ghost ghost merged commit cd4f71d into OpenMW:master Nov 21, 2017
@mychaelo
Copy link

mychaelo commented Nov 21, 2017

But the one thing I don't like about it is how the '+' and '-' don't match up vertically. I guess that can't be fixed as it's a problem with the font.

@scrawl Depends on which character was used. The usual 'fake minus' hyphen is not supposed to be lined up with the plus, but the U+2212 code point 'MINUS SIGN' must do so.

See Wiki pic for comparison: https://en.wikipedia.org/wiki/File:Plus_Minus_Hyphen-minus.svg

@akortunov
Copy link
Collaborator Author

but the U+2212 code point 'MINUS SIGN' must do so.

I tried to use this character previously, but OpenMW does not support it (? is displayed).
I do not know if there is an issue on the engine side, or on the font side.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants