Merge branch 'door_copies' into 'master'

Do not make redundant copies See merge request OpenMW/openmw!4347
OpenMW · Sep 1, 2024 · ba18b81 · ba18b81
2 parents f456978 + b620b9b
commit ba18b81
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/apps/openmw/mwlua/types/door.cpp b/apps/openmw/mwlua/types/door.cpp
@@ -47,18 +47,18 @@ namespace MWLua
             { "Closing", MWWorld::DoorState::Closing },
         }));
         door["getDoorState"] = [](const Object& o) -> MWWorld::DoorState {
-            auto door = doorPtr(o);
+            const MWWorld::Ptr& door = doorPtr(o);
             return door.getClass().getDoorState(door);
         };
         door["isOpen"] = [](const Object& o) {
-            auto door = doorPtr(o);
+            const MWWorld::Ptr& door = doorPtr(o);
             bool doorIsIdle = door.getClass().getDoorState(door) == MWWorld::DoorState::Idle;
             bool doorIsOpen = door.getRefData().getPosition().rot[2] != door.getCellRef().getPosition().rot[2];
 
             return doorIsIdle && doorIsOpen;
         };
         door["isClosed"] = [](const Object& o) {
-            auto door = doorPtr(o);
+            const MWWorld::Ptr& door = doorPtr(o);
             bool doorIsIdle = door.getClass().getDoorState(door) == MWWorld::DoorState::Idle;
             bool doorIsOpen = door.getRefData().getPosition().rot[2] != door.getCellRef().getPosition().rot[2];
 
@@ -70,7 +70,7 @@ namespace MWLua
             if (!allowChanges)
                 throw std::runtime_error("Can only be used in global scripts or in local scripts on self.");
 
-            auto door = doorPtr(o);
+            const MWWorld::Ptr& door = doorPtr(o);
             auto world = MWBase::Environment::get().getWorld();
 
             if (!openState.has_value())