Skip to content

Commit

Permalink
Abandon variable-based job specification
Browse files Browse the repository at this point in the history
You can only use variables to specify the dependency job if you also
specify the project and ref. I couldn't find a built-in variable that
evaluated to the current ref or particularly clear documentation of what
ref even meant in this context (GitLab uses it for a few different
things in CI as far as I can tell).

This is a combination of 2 commits.
This is the 1st commit message:

Project permits variables in job names?

This is the commit message #2:

Using a variable is getting too hard, just copy and paste some stuff

    pick cf1c4dfa73 Project permits variables in job names?
    squash e5e888ac77 Using a variable is getting too hard, just copy and paste some stuff
  • Loading branch information
AnyOldName3 committed Sep 9, 2024
1 parent a8b8eb1 commit 0e842d5
Showing 1 changed file with 21 additions and 17 deletions.
38 changes: 21 additions & 17 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -536,9 +536,6 @@ macOS14_Xcode15_arm64:
.Compress_And_Upload_Symbols_Base:
extends: .Ubuntu_Image
stage: build
needs:
- job: $DEPENDENCY_JOB_NAME
artifacts: true
variables:
GIT_STRATEGY: none
script:
Expand Down Expand Up @@ -668,8 +665,9 @@ macOS14_Xcode15_arm64:
.Windows_Compress_And_Upload_Symbols_Ninja_Release:
extends:
- .Compress_And_Upload_Symbols_Base
variables:
DEPENDENCY_JOB_NAME: "Windows_Ninja_Release"
needs:
- job: "Windows_Ninja_Release"
artifacts: true

.Windows_Ninja_Release_MultiView:
extends:
Expand All @@ -681,8 +679,9 @@ macOS14_Xcode15_arm64:
.Windows_Compress_And_Upload_Symbols_Ninja_Release_MultiView:
extends:
- .Compress_And_Upload_Symbols_Base
variables:
DEPENDENCY_JOB_NAME: "Windows_Ninja_Release_MultiView"
needs:
- job: "Windows_Ninja_Release_MultiView"
artifacts: true

.Windows_Ninja_Debug:
extends:
Expand All @@ -693,8 +692,9 @@ macOS14_Xcode15_arm64:
.Windows_Compress_And_Upload_Symbols_Ninja_Debug:
extends:
- .Compress_And_Upload_Symbols_Base
variables:
DEPENDENCY_JOB_NAME: "Windows_Ninja_Debug"
needs:
- job: "Windows_Ninja_Debug"
artifacts: true

.Windows_Ninja_RelWithDebInfo:
extends:
Expand All @@ -707,8 +707,9 @@ macOS14_Xcode15_arm64:
.Windows_Compress_And_Upload_Symbols_Ninja_RelWithDebInfo:
extends:
- .Compress_And_Upload_Symbols_Base
variables:
DEPENDENCY_JOB_NAME: "Windows_Ninja_RelWithDebInfo"
needs:
- job: "Windows_Ninja_RelWithDebInfo"
artifacts: true

.Windows_Ninja_CacheInit:
# currently, Windows jobs for all configs share the same cache key as we only cache the dependencies
Expand Down Expand Up @@ -809,8 +810,9 @@ macOS14_Xcode15_arm64:
.Windows_Compress_And_Upload_Symbols_MSBuild_Release:
extends:
- .Compress_And_Upload_Symbols_Base
variables:
DEPENDENCY_JOB_NAME: "Windows_MSBuild_Release"
needs:
- job: "Windows_MSBuild_Release"
artifacts: true

.Windows_MSBuild_Debug:
extends:
Expand All @@ -821,8 +823,9 @@ macOS14_Xcode15_arm64:
.Windows_Compress_And_Upload_Symbols_MSBuild_Debug:
extends:
- .Compress_And_Upload_Symbols_Base
variables:
DEPENDENCY_JOB_NAME: "Windows_MSBuild_Debug"
needs:
- job: "Windows_MSBuild_Debug"
artifacts: true

Windows_MSBuild_RelWithDebInfo:
extends:
Expand All @@ -839,8 +842,9 @@ Windows_MSBuild_RelWithDebInfo:
Windows_Compress_And_Upload_Symbols_MSBuild_RelWithDebInfo:
extends:
- .Compress_And_Upload_Symbols_Base
variables:
DEPENDENCY_JOB_NAME: "Windows_MSBuild_RelWithDebInfo"
needs:
- job: "Windows_MSBuild_RelWithDebInfo"
artifacts: true
# temporarily enabled while we're linking the above on the downloads page
rules:
# run this for both pushes and schedules so 'latest successful pipeline for branch' always includes it
Expand Down

0 comments on commit 0e842d5

Please sign in to comment.