Skip to content

Commit

Permalink
Merge branch 'drainmaximummagicka' into 'master'
Browse files Browse the repository at this point in the history
Hide magnitude for Fortify Maximum Magicka when requested as well (#7832)

Closes #7832

See merge request OpenMW/openmw!3868
  • Loading branch information
jvoisin committed Feb 16, 2024
2 parents 1280345 + a0ba0d7 commit 0db7308
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@
Bug #7785: OpenMW-CS initialising Skill and Attribute fields to 0 instead of -1 on non-FortifyStat spells
Bug #7794: Fleeing NPCs name tooltip doesn't appear
Bug #7796: Absorbed enchantments don't restore magicka
Bug #7832: Ingredient tooltips show magnitude for Fortify Maximum Magicka effect
Feature #2566: Handle NAM9 records for manual cell references
Feature #3537: Shader-based water ripples
Feature #5173: Support for NiFogProperty
Expand Down
4 changes: 2 additions & 2 deletions apps/openmw/mwgui/widgets.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ namespace MWGui::Widgets

std::string spellLine = MWMechanics::getMagicEffectString(*magicEffect, attribute, skill);

if (mEffectParams.mMagnMin || mEffectParams.mMagnMax)
if ((mEffectParams.mMagnMin || mEffectParams.mMagnMax) && !mEffectParams.mNoMagnitude)
{
ESM::MagicEffect::MagnitudeDisplayType displayType = magicEffect->getMagnitudeDisplayType();
if (displayType == ESM::MagicEffect::MDT_TimesInt)
Expand All @@ -386,7 +386,7 @@ namespace MWGui::Widgets

spellLine += formatter.str();
}
else if (displayType != ESM::MagicEffect::MDT_None && !mEffectParams.mNoMagnitude)
else if (displayType != ESM::MagicEffect::MDT_None)
{
spellLine += " " + MyGUI::utility::toString(mEffectParams.mMagnMin);
if (mEffectParams.mMagnMin != mEffectParams.mMagnMax)
Expand Down

0 comments on commit 0db7308

Please sign in to comment.