Allow setting support_templates_dir additionally to templates_dir #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sorry for the delay on this. I'm looking at the PR now... |
|
This is great. I'll open an issue to refactor that constructor as it's gotten too complicated and should take a configuration object instead. Thanks @swuerl |
thirtytwobits
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an external template for support code is currently not possible, as it was explicitly disabled to fix a bug:
c7db1bd
I was working around that bug in the past, by just calling nunavut twice, for support and templates, e.g.:
Since version 2.1.0, this is not possible anymore. This PR implements this use-case properly again, by adding an argument
--support-templatesto separate support from struct serialization. So now it becomes: