try/except instead of requiring version kwarg #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjh1
reviewed
Nov 30, 2023
|
|
||
| raise FileNotFoundError( | ||
| "No file with those parameters can be found for any version." | ||
| ) |
There was a problem hiding this comment.
Looks good. You could also avoid the if block by having a list of the functions and using the version as the index ...
There was a problem hiding this comment.
how about new version?
There was a problem hiding this comment.
Sure, although I was thinking of a list, but a dict works too.
cjh1
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid using version kwarg