Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels for Python 3.11 also #295

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Build wheels for Python 3.11 also #295

merged 3 commits into from
Oct 3, 2023

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Aug 17, 2023

I believe Python 3.11 wheels were being skipped because, at the time, several dependencies did not have Python 3.11 support.

But our dependencies should have Python 3.11 support now. So let's add back in Python 3.11.

Fixes: #294

I believe Python 3.11 wheels were being skipped because, at the time,
several dependencies did not have Python 3.11 support.

But our dependencies should have Python 3.11 support now. So let's
add back in Python 3.11.

Signed-off-by: Patrick Avery <[email protected]>
manylinux2010 is no longer supported as of about a year ago. It also
does not contain Python > 3.10.

We should upgrade to the next version, manylinux2014.

Signed-off-by: Patrick Avery <[email protected]>
@psavery
Copy link
Collaborator Author

psavery commented Aug 17, 2023

@cjh1 I updated the dockerhub wheelbuilder to use manylinux2014 instead of manylinux2010. This is because manylinux2010 is no longer supported as of about a year ago. manylinux2010 also does not contain python3.11, but manylinux 2014 does.

Our current version of pybind11 doesn't build with Python 3.11.
We need to upgrade. v2.11.1 is the latest version of pybind11.

Signed-off-by: Patrick Avery <[email protected]>
@psavery
Copy link
Collaborator Author

psavery commented Aug 17, 2023

After adding Python 3.11, upgrading our docker image to manylinux2014, and upgrading pybind11 to the latest version, building the Python 3.11 wheels now appears to work!

@ercius feel free to download a Python 3.11 wheel from here to give it a try. I hope upgrading pybind11 didn't introduce any issues.

Once this PR is approved, we can merge it, and then push a tag, and then Python 3.11 wheels should be available on PyPI.

@swelborn
Copy link
Collaborator

looks good.

@ercius should still check if all functionality is still there after upgrading pybind11.

Copy link
Member

@cjh1 cjh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psavery psavery merged commit 2c8aa53 into master Oct 3, 2023
5 checks passed
@psavery psavery deleted the python3.11 branch October 3, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.11 installs stempy 0.0.1
3 participants