Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] added missing exportContext in global search (#8421) #8423

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Sep 19, 2024

Proposed changes

  • global search was missing export button

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec JeremyCloarec linked an issue Sep 19, 2024 that may be closed by this pull request
@JeremyCloarec JeremyCloarec added the filigran team use to identify PR from the Filigran team label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (5a24ef2) to head (6af2577).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8423   +/-   ##
=======================================
  Coverage   66.14%   66.14%           
=======================================
  Files         597      597           
  Lines       60382    60382           
  Branches     6193     6194    +1     
=======================================
  Hits        39937    39937           
  Misses      20445    20445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec merged commit c129af0 into master Sep 19, 2024
6 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/8421 branch September 19, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export button is missing in the global search
2 participants