[frontend] Bulk edition of status regression fix (#8393) #8400
Conversation
Archidoit
force-pushed
the
issue/8393
branch
from
cc372ee
to
c0cddce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8400 +/- ##
=======================================
Coverage 66.13% 66.14%
=======================================
Files 597 597
Lines 60374 60374
Branches 6191 6192 +1
=======================================
+ Hits 39931 39936 +5
+ Misses 20443 20438 -5 ☔ View full report in Codecov by Sentry. |
|
is it possible to add a non regression test for this usecase ? |
| if (selectedTypes.length === 1) { | ||
| [selectedType] = selectedTypes; | ||
| } else { | ||
| throw Error('It is not possible to bulk edit statuses if more than one entity type is selected.'); |
There was a problem hiding this comment.
that would show as an error in the UI ?
There was a problem hiding this comment.
theoretically, it's not possible to have this error since we check in the code that only one entity type is selected. It's to prevent bad changing of code in the future if someone don't exactly know what he is doing ;)
|
I can now update vulnerabilities status in mass ops from Vuln list, but not from Entities view. Is it expected ? |
status is open vocab, might be different from entities to entities, so definitely not an issue. |
|
@labo-flg Yes it's expected because entities of different type have different possible values for 'status' |
Proposed changes
Fix a regression: it was not possible anymore to bulk edit Status via the toolbar
Related issues
#8393