Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] improve organization sharing (#4538) #8301

Merged
merged 15 commits into from
Sep 17, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Sep 10, 2024

Proposed changes

  • improve orga sharing: No restriction if no orga platform
    • 3 updates
    • 3 raw events

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.18%. Comparing base (a73a239) to head (fbb9d98).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8301      +/-   ##
==========================================
- Coverage   66.19%   66.18%   -0.01%     
==========================================
  Files         597      597              
  Lines       60396    60375      -21     
  Branches     6207     6209       +2     
==========================================
- Hits        39978    39959      -19     
+ Misses      20418    20416       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact force-pushed the issue/4538_orga_sharing_improvment branch 3 times, most recently from 7c1b649 to 8b830f3 Compare September 13, 2024 16:40
@marieflorescontact marieflorescontact marked this pull request as ready for review September 13, 2024 17:19
@marieflorescontact marieflorescontact force-pushed the issue/4538_orga_sharing_improvment branch 2 times, most recently from cca100f to 097b72d Compare September 16, 2024 12:25
@aHenryJard aHenryJard self-assigned this Sep 17, 2024
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, all good for me. Tested with both a plateform orga and no platform orga setup, and with a user that is in "another" organization.

@marieflorescontact marieflorescontact merged commit 4707bf5 into master Sep 17, 2024
6 checks passed
@marieflorescontact marieflorescontact deleted the issue/4538_orga_sharing_improvment branch September 17, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants