-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved accessibility for static labels and chips #8239
Open
Bonsai8863
wants to merge
7
commits into
OpenCTI-Platform:master
Choose a base branch
from
fbicyber:feature/monochrome_labels/static_labels
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improved accessibility for static labels and chips #8239
Bonsai8863
wants to merge
7
commits into
OpenCTI-Platform:master
from
fbicyber:feature/monochrome_labels/static_labels
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8239 +/- ##
==========================================
- Coverage 66.14% 66.13% -0.01%
==========================================
Files 597 597
Lines 60382 60382
Branches 6192 6191 -1
==========================================
- Hits 39937 39932 -5
- Misses 20445 20450 +5 ☔ View full report in Codecov by Sentry. |
Bonsai8863
force-pushed
the
feature/monochrome_labels/static_labels
branch
from
September 4, 2024 12:17
f27aa82
to
d8553e5
Compare
Bonsai8863
force-pushed
the
feature/monochrome_labels/static_labels
branch
4 times, most recently
from
September 11, 2024 15:02
4d383d7
to
9fb1918
Compare
Bonsai8863
force-pushed
the
feature/monochrome_labels/static_labels
branch
3 times, most recently
from
September 17, 2024 12:53
77c49f4
to
4087e2d
Compare
SamuelHassine
force-pushed
the
master
branch
from
September 17, 2024 15:10
f8359b7
to
558e6c1
Compare
Bonsai8863
force-pushed
the
feature/monochrome_labels/static_labels
branch
2 times, most recently
from
September 18, 2024 14:57
76cbae8
to
704f6b8
Compare
Bonsai8863
force-pushed
the
feature/monochrome_labels/static_labels
branch
from
September 19, 2024 14:28
704f6b8
to
29b2692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
I didn't write auto tests since they are mostly style changes