Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved accessibility for static labels and chips #8239

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Bonsai8863
Copy link
Contributor

Proposed changes

  • Changed text color for most labels/chips to pure black/white to improve readability
  • Added monochromatic setting in user profile to make labels/chips completely grayscale

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

I didn't write auto tests since they are mostly style changes

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.13%. Comparing base (68efd7f) to head (29b2692).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8239      +/-   ##
==========================================
- Coverage   66.14%   66.13%   -0.01%     
==========================================
  Files         597      597              
  Lines       60382    60382              
  Branches     6192     6191       -1     
==========================================
- Hits        39937    39932       -5     
- Misses      20445    20450       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bonsai8863 Bonsai8863 force-pushed the feature/monochrome_labels/static_labels branch from f27aa82 to d8553e5 Compare September 4, 2024 12:17
@Bonsai8863 Bonsai8863 marked this pull request as draft September 4, 2024 17:49
@Kedae Kedae added the community use to identify PR from community label Sep 8, 2024
@Bonsai8863 Bonsai8863 force-pushed the feature/monochrome_labels/static_labels branch 4 times, most recently from 4d383d7 to 9fb1918 Compare September 11, 2024 15:02
@Bonsai8863 Bonsai8863 marked this pull request as ready for review September 11, 2024 15:22
@Bonsai8863 Bonsai8863 force-pushed the feature/monochrome_labels/static_labels branch 3 times, most recently from 77c49f4 to 4087e2d Compare September 17, 2024 12:53
@Bonsai8863 Bonsai8863 force-pushed the feature/monochrome_labels/static_labels branch 2 times, most recently from 76cbae8 to 704f6b8 Compare September 18, 2024 14:57
@Bonsai8863 Bonsai8863 force-pushed the feature/monochrome_labels/static_labels branch from 704f6b8 to 29b2692 Compare September 19, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants