Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md dockerhub example to match recommendation #317

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

hwine
Copy link
Contributor

@hwine hwine commented Nov 20, 2021

Have dockerhub example use the "stable" version as suggested

Summary

Description for the changelog

Other info

Have dockerhub example use the "stable" version as suggested
Copy link
Collaborator

@lreading lreading left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I thought it would be good to keep the specific version tag, as I think that's how most people will wind up deploying it in their environment. I think it does make more sense to use the stable tag in the readme for a few reasons, one of which being that it matches the dockerhub example as you've brought up here. Another is that we won't need to update the readme each time we release, which is just one less thing to forget later. 😁

Thanks for raising the issue and opening the PR! Feel free to merge!

@hwine
Copy link
Contributor Author

hwine commented Nov 20, 2021

Thanks for raising the issue and opening the PR! Feel free to merge!

I can't merge, as I don't have (or need) write permissions in the repo! 😀 This was just a drive-by doc update (though I will be watching the project).

@lreading lreading merged commit db6d027 into OWASP:main Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants