Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter file type consumes, confusing language #512

Closed
vanderlee opened this issue Nov 20, 2015 · 5 comments
Closed

Parameter file type consumes, confusing language #512

vanderlee opened this issue Nov 20, 2015 · 5 comments

Comments

@vanderlee
Copy link
Contributor

In the Parameter Object definition of the type property, the following is stated:

If type is "file", the consumes MUST be either "multipart/form-data" or "application/x-www-form-urlencoded"

Interpreting this strictly would mean that consumes MAY NOT contain both "multipart/form-data" and "application/x-www-form-urlencoded" but MUST contain no more or less than one of those two choices. This restriction seems odd to me.
Could anybody please clarify if the above interpretation is correct.

@webron
Copy link
Member

webron commented Nov 20, 2015

It can be either one or both.

@vanderlee
Copy link
Contributor Author

So basically "A and/or B" rather than "either A or B" (http://dictionary.cambridge.org/dictionary/english/either-or)

This language construct appears to be used in a few other places in the documentation as well, I believe some of those may similarly be incorrect.

Shall I make a pull request for this?

@webron
Copy link
Member

webron commented Nov 20, 2015

Please do. I'll review the changes and add comments if needed.

@vanderlee
Copy link
Contributor Author

Just added a pull request #514. Only two found. Other uses of "either/or" seem appropriate as is.

@webron webron closed this as completed in b9476ee Nov 24, 2015
webron added a commit that referenced this issue Nov 24, 2015
Fix #512; change either/or where both are allowed
@webron
Copy link
Member

webron commented Nov 24, 2015

Thanks for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants