Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail task upon function execution error #36

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fail task upon function execution error #36

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e89c7c
Handle case when invocation succeeds but execution of function fails.
May 29, 2020
edfa2d9
Print additional information when the Lambda fails. The response payl…
May 29, 2020
b4c8f78
Added two simple testcases related to function execution failure.
May 29, 2020
0e238b5
Simplifying. Upon function error the 'FunctionError' field is non-emp…
May 29, 2020
705ad3f
Fixed comment
May 29, 2020
9d7cb68
'FunctionError' field is not set in the response, i.e it is either nu…
May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
'FunctionError' field is not set in the response, i.e it is either nu… 
…ll or empty string
  • Loading branch information
rickard.cardell committed May 29, 2020
commit 9d7cb68ecd45e986194571a663e34c439269fd49
2 changes: 1 addition & 1 deletion src/main/java/com/nordstrom/kafka/connect/lambda/LambdaSinkTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ void handleResponse(
final long backoffTimeMs) {

String functionError = response.getErrorString();
if (! functionError.isEmpty()) {
if (functionError != null && !functionError.isEmpty()) {
//function-error
throw new FunctionExecutionException(MessageFormat
.format("Lambda function execution failed. Reason: {0}: {1}",
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/nordstrom/kafka/connect/lambda/LambdaSinkTaskTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void testHandleResponseWhenFunctionExecutionFails() {
public void testHandleResponseWhenFunctionInvocationAndExecutionSucceeds() {

LambdaSinkTask task = new LambdaSinkTask();
InvocationResponse invocationResponse = new InvocationResponse(200, "test log", "", null, Instant.now(), Instant.now());
InvocationResponse invocationResponse = new InvocationResponse(200, "test log", null, null, Instant.now(), Instant.now());
AtomicInteger retryCounter = new AtomicInteger(2);

task.handleResponse(invocationResponse, retryCounter, Arrays.asList(501,504), 3, 1L);
Expand Down