Added an error message when using enableFakechroot under darwin #327336
Conversation
|
Uses the following patch from @the-sun-will-rise-tomorrow : #327311 (comment) |
| @@ -561,6 +561,8 @@ This allows the function to produce reproducible images. | |||
| This allows scripts that perform installation in `/` to work as expected. | |||
| This can be seen as an equivalent of `RUN ...` in a `Dockerfile`. | |||
|
|
|||
| This does not work under `darwin`! | |||
There was a problem hiding this comment.
I am not sure about this, as I don't see a similar mention elsewhere in the documentation - not sure if that's simply because there's a convention of not mentioning incompatibilities due to bugs or implementation deficiencies, or simply because the situation doesn't occur that much. Regardless, I think this needs to be aligned with the paragraph above.
There was a problem hiding this comment.
@NixOS/documentation-team Do you guys have input on this? Is there a convention we're not aware of? And would you think this is fitting? Any input is appreciated! 🫶
There was a problem hiding this comment.
Thanks for the ping. I'm not excited about leaving documentation that may get out of date. Sure, reading that in the manual before running into the problem would be great, but I'd err towards maintainability here. If the error is self-explanatory, it should be good enough. I strongly recommend explaining in the error message why it doesn't work on Darwin and what to do about it (e.g. workarounds or upvoting an issue so we can keep track of interest).
There was a problem hiding this comment.
I've removed the documentation part and have added a bit more text to the assert error message. Thanks for the input!
Really helpful to get those kind of insights when only starting the journey of contributing. Thank you!
Mastermindaxe
force-pushed
the
327311_add_error_message_to_enableFakechroot_under_darwin
branch
from
4d53d08
to
075dcc2
Compare
Mastermindaxe
force-pushed
the
327311_add_error_message_to_enableFakechroot_under_darwin
branch
from
075dcc2
to
7348878
Compare
Mastermindaxe
changed the title
|
@Mastermindaxe thanks a lot, this is a nice self-contained contribution that makes an obvious improvement to user experience. Keep at it! |
@fricklerhandwerk Thank you for that! |
Mastermindaxe
deleted the
327311_add_error_message_to_enableFakechroot_under_darwin
branch
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.