Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lollypop: switch youtubeSupport dependency to yt-dlp #326444

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

21CSM
Copy link
Member

@21CSM 21CSM commented Jul 12, 2024

Description of changes

Fixes #326377

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested placyback via YouTube, works as expected

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • lollypop

@ofborg ofborg bot requested a review from lovesegfault July 12, 2024 04:03
@SuperSandro2000 SuperSandro2000 merged commit f322e8f into NixOS:master Jul 17, 2024
32 checks passed
@21CSM 21CSM deleted the lollypop-switch-to-yt-dlp branch July 17, 2024 12:25
@CoderThomasB
Copy link

Could this be backported to 24.05 as it's also causing build problems on that version?

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: lollypop
4 participants