Create signal hooks and handler for dumping CSR and certificate details #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased (-0.007%) to 60.771% when pulling 667d9ed03cd87a32f63e691dd3ffd951ceb379f0 on intgr:cert-csr-debug-dumps into 7762d6e on Netflix:master. |
intgr
force-pushed
the
cert-csr-debug-dumps
branch
from
667d9ed
to
2de9bc7
Compare
|
This looks generally useful, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been quite useful for debugging various Lemur integrations and CA configuration: who sends/requests what and how the certificate looks like in the end. Since it shows more information than Lemur itself.
I don't know if you want to merge this whole. Alternatively you I could only submit the signals part and I can refactor the rest out into a plugin for myself.