Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common name auto addition as domain name #2804

Merged
merged 3 commits into from
Jun 5, 2019

Conversation

kush-bavishi
Copy link
Contributor

Changes to allow automatically add the common name to the list of Domain names. How it works - When the user types a common name and moves focus from the text box, the common name gets added to the list of Domain Names. Any further edits to the common name will be appropriately reflected in the list on Domain names automatically as well.

image
Text box is in focus and the list of domain names is empty.

image
Text box loses focus, common name gets added to list

image
Subsequent alternate names get added to the list after the common name

image
Common name modified, changes reflect in the list of domain names

@coveralls
Copy link

coveralls commented May 31, 2019

Coverage Status

Coverage remained the same at 60.247% when pulling 24f5ce7 on kush-bavishi:CommonNameAutoAdditionAsDNS into f991317 on Netflix:master.

@hosseinsh
Copy link
Contributor

Thanks Kush for the PR. merging it.

@hosseinsh hosseinsh merged commit 3a512d5 into Netflix:master Jun 5, 2019
@kush-bavishi kush-bavishi deleted the CommonNameAutoAdditionAsDNS branch June 7, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants