Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SAN filter to Vault Destination Plugin #2759

Merged
merged 9 commits into from
Apr 24, 2019
Merged

Adding SAN filter to Vault Destination Plugin #2759

merged 9 commits into from
Apr 24, 2019

Conversation

alwaysjolley
Copy link
Contributor

Adds a regex filter to prevent non-matching SAN names from being uploaded to the Vault Destination.

  • This filter is completely optional, defaults to pass
  • If and SAN fails the regex filter the cert will not upload to Vault and the plugin will error
  • Logs record the certificate did not pass the SAN filter
  • Allows for more granular control of SAN certificates allowed per destination.

@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 61.509% when pulling 6804bfb on alwaysjolley:lemur_vault_plugin into 07e8e6a on Netflix:master.

@hosseinsh
Copy link
Contributor

Thanks for the PR. Merging this.

@hosseinsh hosseinsh merged commit 21d619e into Netflix:master Apr 24, 2019
@alwaysjolley alwaysjolley deleted the lemur_vault_plugin branch April 24, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alwaysjolley @coveralls @hosseinsh