Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Gradle 4 #533

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Upgrade to Gradle 4 #533

merged 1 commit into from
Jun 19, 2017

Conversation

tgianos
Copy link
Contributor

@tgianos tgianos commented Jun 16, 2017

No description provided.

@tgianos tgianos added this to the 3.1.0 milestone Jun 16, 2017
@tgianos tgianos self-assigned this Jun 16, 2017
@tgianos tgianos requested a review from mprimi June 16, 2017 17:41
@coveralls
Copy link

coveralls commented Jun 16, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.63% when pulling 99b9293 on tgianos:gradle4 into 61477f2 on Netflix:master.

mprimi
mprimi approved these changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@mprimi mprimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do you mind if I holding off merging for a bit until i have a second to try it locally?
Just want to make sure all features I'm using (IDEA, single test, dependency tree, etc are working).

@mprimi
Copy link
Contributor

mprimi commented Jun 19, 2017

Tried this. Seems to work just like before, but faster 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.63% when pulling f5bbe5d on tgianos:gradle4 into 61477f2 on Netflix:master.

@tgianos tgianos merged commit 3c1a809 into Netflix:master Jun 19, 2017
@tgianos tgianos deleted the gradle4 branch June 19, 2017 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprimi mprimi mprimi approved these changes

Assignees

@tgianos tgianos

Labels
Improvement
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tgianos @coveralls @mprimi