bump spring_boot_version to 2.7.+ #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhou2
force-pushed
the
dev-snapshot
branch
30 times, most recently
from
6863809
to
6b79fbd
Compare
bhou2
force-pushed
the
dev-snapshot
branch
17 times, most recently
from
54aca02
to
e469a95
Compare
bhou2
changed the title
bhou2
force-pushed
the
dev-snapshot
branch
2 times, most recently
from
09d69f6
to
351c821
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1193 +/- ##
=========================================
Coverage 90.75% 90.75%
Complexity 3809 3809
=========================================
Files 467 467
Lines 14976 14976
Branches 1071 1071
=========================================
Hits 13591 13591
Misses 909 909
Partials 476 476 ☔ View full report in Codecov by Sentry. |
stevie9868
reviewed
Nov 22, 2023
| @@ -141,7 +141,7 @@ spring: | |||
| repositories: | |||
| enabled: false | |||
| datasource: | |||
| url: jdbc:h2:mem:genie | |||
| url: jdbc:h2:mem:genie;MODE=MySQL;DB_CLOSE_DELAY=-1;DATABASE_TO_LOWER=TRUE;CASE_INSENSITIVE_IDENTIFIERS=TRUE;NON_KEYWORDS=value,limit; | |||
There was a problem hiding this comment.
I assume our test case is comprehensive, and since all test cases are passed, I think it should be safe but want to bring this up again to double confirm that there should have no risk with such change.
There was a problem hiding this comment.
Yes. It is safe. This change is required as H2 is upgraded from 1.4 to 2.1.
stevie9868
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to migrate Genie OSS SBN from 2.6.7 to 2.7.+ (i.e., bump spring_boot_version to 2.7.+). This migration is not backwards compatible (see https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes).
In particular, for Genie: (1) H2database from 1.4 to 2.1.; (2) MySQL from 5.7 to 8.0; (3) PostgreSQL from 9.6 to 10; (4) Flyway from 7.x to 9.x. Accordingly, the related sql scripts / implementations, configurations, and dependencies need upgrades.
Tests have been done: (1) local gradle build; (2) genie build on github actions; (3) deployment and tests on personal genie stack.